Skip to content

⚒️🎨 Migrate to MapLibre#5962

Open
AndyScherzinger wants to merge 14 commits intomasterfrom
feat/noid/migrateToMapLibre
Open

⚒️🎨 Migrate to MapLibre#5962
AndyScherzinger wants to merge 14 commits intomasterfrom
feat/noid/migrateToMapLibre

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Mar 12, 2026 •
edited
Loading

  • replace OSMdroid with MapLibre and re-implement/preserve the features (current location, zoom, etc)
  • ensure geoActivity result is preserved upon device rotation or any other non-location-changing action
  • migrate from raster to vector tiles with nice color schemes for dark/light. You can use maputnik to load the json themes for display and editing
  • Implement attribution / info

🖼️ Screenshots

🏚️ Before 🏡 After
old_light new_light2
old_dark new_dark2

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger requested a review from mahibi March 12, 2026 20:34
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Mar 12, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from eef1c13 to cd08216 Compare March 14, 2026 13:43
@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 14, 2026
@AndyScherzinger AndyScherzinger changed the title feat: Migrate to MapLibre ⚒️🎨 Migrate to MapLibre Mar 14, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch 5 times, most recently from e13e9f9 to c13c1da Compare March 15, 2026 10:22
@AndyScherzinger AndyScherzinger marked this pull request as ready for review March 15, 2026 10:55
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from f890949 to 395700d Compare March 15, 2026 11:07
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to the design and removed 2. developing Work in progress labels Mar 15, 2026
@AndyScherzinger
feat: Migrate to MapLibre
682723e 
AI-assistant: Claude Code v2.1.74 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: Migrate to vector tiles
60b744b 
AI-assistant: Claude Code v2.1.74 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: improve map logging and preview/message element itself, slightl…
d8b588d 
…y shorten code

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Move view-models from general package to feature-sub-package
9e69536 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Combine init methods into a single call to the model
ef24012 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: Hide scale bar
439def5 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
docs: Add license files for json files
9bf8fda 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(lint): MapLibre pulls in Timber producing a lot of lint warnings
4f44184 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(map): add proper, expanding attribution button
b1beab1 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(map): Display current location
b77e8fa 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: extract keys to constants
febfade 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Preserve placeName on zooming
128a04c 
(position change is smaller than COORDINATE_EPSILON translating to 0,11m)

AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: Optimize colors of dark/light map themes for better contrast
e7c6df6 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Fix location test
7e7b57c 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from 4e5bb53 to 7e7b57c Compare March 15, 2026 16:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5962.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2026

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

23.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger