Perf: Optimize shares loading by eliminating N+1 queries#2293
Merged
Conversation
Koc
force-pushed
the
feature/optimize-shares-loading
branch
4 times, most recently
from
0bef51a to
dd7dd5e
Compare
Koc
force-pushed
the
feature/optimize-shares-loading
branch
2 times, most recently
from
d5ac3e9 to
c77f89a
Compare
Koc
force-pushed
the
feature/optimize-shares-loading
branch
from
c77f89a to
50fdced
Compare
blizzz
reviewed
Feb 12, 2026
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Thanks for this approach! Left a few comments, but nothing big.
Koc
force-pushed
the
feature/optimize-shares-loading
branch
5 times, most recently
from
d4a78f3 to
5c55f11
Compare
Koc
commented
Feb 14, 2026
Koc
force-pushed
the
feature/optimize-shares-loading
branch
3 times, most recently
from
859b352 to
98bb04a
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/optimize-shares-loading
branch
from
98bb04a to
93affa8
Compare
… fixes) Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/optimize-shares-loading
branch
from
93affa8 to
da356e9
Compare
blizzz
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation
SharesService::findTablesSharedWithMe()generates repeatable queries for each view/table/group/circle.This PR optimizes loading of that data by execution single
WHERE INquery for each entity, so we have constant queries count.Inspired by #1749.
Next steps for optimization (separate PRs):
TableService::enhanceTable()ViewService::enhanceView()