Open
Conversation
Koc
force-pushed
the
feature/add-relations-column-type
branch
from
c3f6a2d to
fdd744e
Compare
Koc
force-pushed
the
bugfix/fix-loading-of-large-tables
branch
from
f792683 to
f599f40
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
6 times, most recently
from
92af03c to
0f9416b
Compare
Open
Koc
force-pushed
the
feature/add-relations-column-type
branch
3 times, most recently
from
6a4e073 to
5209182
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
4 times, most recently
from
fb98364 to
198afa1
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
from
198afa1 to
ddc1bd1
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
2 times, most recently
from
f34f8f9 to
d406233
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
4 times, most recently
from
f092bad to
502b69b
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
from
502b69b to
8093d63
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
7 times, most recently
from
d45b95c to
cb637bd
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
enjeck
force-pushed
the
feature/add-relations-column-type
branch
from
cb637bd to
9b36f43
Compare
enjeck
reviewed
Mar 4, 2026
Contributor
enjeck
left a comment
enjeck
left a comment
There was a problem hiding this comment.
Thanks, it works quite well already. A few comments for now. I have only tested the creation of columns and rows so far
| }) | ||
| this.availableLabelColumns = columns | ||
| .filter(column => | ||
| column instanceof NumberColumn || column instanceof TextLineColumn, |
Contributor
There was a problem hiding this comment.
why restrict to just these 2 column types?
Contributor
There was a problem hiding this comment.
it seems like the relation should easily generalise to all column types
Comment on lines
+167
to
+177
| $targetColumn = $this->columnMapper->find($settings[Column::RELATION_LABEL_COLUMN]); | ||
| if ($isView) { | ||
| $view = $this->viewMapper->find($targetId); | ||
| $rows = $this->row2Mapper->findAll( | ||
| [$targetColumn->getId()], | ||
| $view->getTableId(), | ||
| null, | ||
| null, | ||
| $view->getFilterArray(), | ||
| $view->getSortArray(), | ||
| $this->userId |
Contributor
There was a problem hiding this comment.
Do we ever consider permissions such that the user must have access to the table/view before they can link to it?
|
|
||
| public function formatRowData(Column $column, array $row) { | ||
| $value = $row['value']; | ||
| return (int)$value; |
Contributor
There was a problem hiding this comment.
int(null) is 0. Is 0 a valid id? Could this cause troube?
| <div v-if="!isEditing" class="non-edit-mode" @click="handleStartEditing"> | ||
| <div v-if="isDeleted"> | ||
| <span class="deleted">{{ value }}</span> | ||
| <span class="cursor-help" :title="t('tables', 'This relation is not exists anymore.')"> ⚠️</span> |
Contributor
There was a problem hiding this comment.
Suggested change
| <span class="cursor-help" :title="t('tables', 'This relation is not exists anymore.')"> ⚠️</span> | |
| <span class="cursor-help" :title="t('tables', 'This relation does not exist anymore.')"> ⚠️</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic relation type. It allows to connect few tables together. We will store row id as a column value and display selected column as a label for this values. Closes #172.
✔️ Implemented
🔍 Column create/edit
🔍 Row create/edit via popup/inline
🔍 Row display in table/view + handle relation row removal
🔍 Filter for view
🔍 Filter for rows
🔍 Import/Export
🚧 Pending (help welcomed):
❎ What is out of scope: