fix(performance): Avoid checking existence of default notes folder 3 times #1614
+54
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
JuliaKirschenheuter and
enjeck
as code owners
CarlSchwan
commented
Aug 12, 2025
| 'notesPath' => [ | ||
| 'default' => function (string $uid) { | ||
| return $this->getDefaultNotesPath($uid); | ||
| return $this->getDefaultNotesNode($uid)['path']; |
Member
Author
There was a problem hiding this comment.
not the biggest fan of that, I wonder if it would make sense to keep the old getDefaultNotesPath as it is for this part
…times In the case where the user didn't change their default notes folder. In the worst case, if the user did change their default notes folder we keep the same amount of queries as before. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
AndyScherzinger
force-pushed
the
avoid-checking-existence-3-times
branch
from
07e3578 to
c4b3f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the user didn't change their default notes folder.
In the worst case, if the user did change their default notes folder we keep the same amount of queries as before.