Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #166. After the fix, when you have a
project_nameparam, your artboard images AND your html file all have a name that reflects theproject_nameparam. If no param is indicated, it still defaults back to the illustrator file name, as intended.Worth noting that
output: multiple-filesalready prints out filenames that match theproject_nameparameter. This change bringsoutput: one-filesettings in line with that and with previous versions of ai2html.If the current setup (always using
getRawDocumentName()forone-fileprojects) is intended behavior, feel free to close this PR.