Allow NaN values in unsupervised random forest#358
Open
weioren wants to merge 7 commits intoneurodata:mainfrom
Open
Allow NaN values in unsupervised random forest#358weioren wants to merge 7 commits intoneurodata:mainfrom
weioren wants to merge 7 commits intoneurodata:mainfrom
Conversation
for more information, see https://pre-commit.ci
Collaborator
|
Hi @weioren note this will not enable splitting on missing values, as the core logic within Cython needs to get implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Changed fit function in _unsupervised_forest.py to add ensure_all_finite = "allow-nan" parameter to ensure NaN values are always allowed.
Any other comments?