Conversation
There was a problem hiding this comment.
Pull request overview
Removes the modelmesh-enabled OpenShift namespace label from this plugin’s default namespace labels to avoid forcing a specific model-serving configuration in RHOAI namespaces.
Changes:
- Removed
modelmesh-enabled: "true"fromPROJECT_DEFAULT_LABELS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PROJECT_DEFAULT_LABELS = { | ||
| "opendatahub.io/dashboard": "true", | ||
| "modelmesh-enabled": "true", | ||
| "nerc.mghpcc.org/allow-unencrypted-routes": "true", | ||
| "nerc.mghpcc.org/project": "true", | ||
| } |
There was a problem hiding this comment.
Removing modelmesh-enabled from PROJECT_DEFAULT_LABELS prevents it from being added to new namespaces, but existing namespaces will keep the label because validate_allocations' sync_openshift_project_labels only adds missing labels and never removes labels that are no longer defaults. If the goal is to unblock model-serving selection for existing RHOAI namespaces too, consider explicitly deleting modelmesh-enabled during validation/migration when --apply is used (without removing other user-managed labels).
There was a problem hiding this comment.
@IsaiahStapleton do you want modelmesh-enabled: True to be removed from all existing namespaces?
There was a problem hiding this comment.
@Milstein What do you think? I think no, because the user can already change it themselves so it might be disruptive to change all of them now like that.
There was a problem hiding this comment.
@IsaiahStapleton so you just want the label to not be added for new namespaces going forward?
There was a problem hiding this comment.
@knikolla I think that's what would be best yes. Not sure what others think.
The default Openshift label `modelmesh-enabled` has been removed. This label prevents the user from choosing the model-serving option in their namespace, which is the desired user behavior. More details here: nerc-project/operations#1017
QuanMPhm
force-pushed
the
ops_1017/model_serve
branch
from
8e923fc to
8cbdd29
Compare
3 participants
Closes nerc-project/operations#1017
The default Openshift label
modelmesh-enabledhas been removed. This label prevents the user from choosing the model-serving option in their RHOAI namespace, which is the desired user behavior.More details in the linked issue being closed