Allow direct communication to Openshift API through get_federated_user#177
Merged
QuanMPhm merged 1 commit intonerc-project:mainfrom Mar 25, 2025
Merged
Conversation
naved001
reviewed
Oct 31, 2024
larsks
reviewed
Oct 31, 2024
QuanMPhm
force-pushed
the
175/merge_get_federated
branch
from
73b751b to
8839477
Compare
This was referenced Nov 5, 2024
knikolla
requested changes
Nov 14, 2024
Collaborator
knikolla
left a comment
knikolla
left a comment
There was a problem hiding this comment.
Overall looks pretty good, some comments.
QuanMPhm
force-pushed
the
175/merge_get_federated
branch
from
8839477 to
54922e7
Compare
Contributor
Author
As the first step towards merging the account manager into our coldfront cloud plugin, the `get_federated_user` function in the Openshift allocator will now (through several functions) directly call the Openshift API. Much of the functions added are copied from the `moc_openshift` module in the account manager. Aside from copying some functions, implementation of this feature also involved: - A new resource attribute `Identity Name` for the Openshift idp - A new unit test for the `get_federated_user` function - Changes to the CI file to enable these new unit tests - A top-level logger for the Openshift allocator - New additions to the package requirements
QuanMPhm
force-pushed
the
175/merge_get_federated
branch
from
54922e7 to
6752900
Compare
|
Fix merged, can we kick off the test again? |
Contributor
Author
|
@joachimweyl Yep, now the tests are passing |
Collaborator
|
I'll review this week, though don't want to rush this in for tomorrow's maintenance window. |
knikolla
approved these changes
Feb 26, 2025
Collaborator
knikolla
left a comment
knikolla
left a comment
There was a problem hiding this comment.
Looks good to me.
Would like @larsks or @naved001 to do a review too.
After this one merges, can you please do quota operations, and then project operations?
Quota is higher priority than the users because currently that is the only one that requires changes to acct-mgt everytime we add a new quota type.
naved001
approved these changes
Mar 18, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175. As the first step towards merging the account manager into our coldfront cloud plugin, the
get_federated_userfunction in the Openshift allocator will now (through several functions) directly call the Openshift API. Much of the functions added are copied from themoc_openshiftmodule in the account manager.Aside from copying some functions,
implementation of this feature also involved:
Identity Namefor the Openshift idpget_federated_userfunction