Skip to content

Refine required flag validation#34

Merged
ncode merged 1 commit intomainfrom
fix/required-flag-validation
Feb 13, 2026
Merged

Refine required flag validation#34
ncode merged 1 commit intomainfrom
fix/required-flag-validation

Conversation

@ncode
Copy link
Owner

@ncode ncode commented Feb 13, 2026

Summary

  • Moved required flag validation for run and cleanup commands from Cobra-level required flags to command handlers.
  • run now explicitly returns clear errors when service-id or script is missing.
  • cleanup now explicitly requires service-id while leaving script optional since it is not used.
  • Updated command tests to validate new error messages and removed assumptions about Cobra-required flag behavior.

Verification

  • go test ./cmd/...
  • go test ./...

Closes: N/A

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (d8fd2ca) to head (f8b61b9).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   89.75%   89.94%   +0.19%     
==========================================
  Files           8        8              
  Lines         361      368       +7     
==========================================
+ Hits          324      331       +7     
  Misses         25       25              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ncode ncode merged commit 8a12db7 into main Feb 13, 2026
9 checks passed
@ncode ncode deleted the fix/required-flag-validation branch February 13, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant