Skip to content

Adjust key generating in the library#29

Open
5ZYSZ3K wants to merge 2 commits intomainfrom
28-two-children-with-the-same-key
Open

Adjust key generating in the library#29
5ZYSZ3K wants to merge 2 commits intomainfrom
28-two-children-with-the-same-key

Conversation

@5ZYSZ3K
Copy link
Collaborator

@5ZYSZ3K 5ZYSZ3K commented Mar 1, 2026

Closes #28

@5ZYSZ3K 5ZYSZ3K self-assigned this Mar 1, 2026
@5ZYSZ3K 5ZYSZ3K linked an issue Mar 1, 2026 that may be closed by this pull request
@5ZYSZ3K 5ZYSZ3K requested a review from jsamr March 1, 2026 19:14
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (acd9f87) to head (23b5fbf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files         140      140           
  Lines        2076     2083    +7     
  Branches      633      633           
=======================================
+ Hits         2048     2055    +7     
  Misses         27       27           
  Partials        1        1           
Flag Coverage Δ
css-processor 100.00% <ø> (ø)
render 97.84% <100.00%> (+0.01%) ⬆️
transient-render-engine 98.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

} else {
if (wrapperChildren.length) {
newChildren.push(wrapper);
wrapper.bindChildren(wrapperChildren);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsamr I've checked the usage of nodeIndex, and it seems like the only thing that could break because of that is removing top and bottom margins in <li> components, but I tested it and it seems like it's working fine

@5ZYSZ3K
Copy link
Collaborator Author

5ZYSZ3K commented Mar 1, 2026

@jsamr By the way:
We've scheduled the first major release to this tuesday (this one won't be included). Would you be able to mark the react-native-render-html library as deprecated then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two children with the same key

1 participant