Test version refactor : column config and rendering#1004
Open
kala-moz wants to merge 3 commits intomozilla:mainfrom
Open
Test version refactor : column config and rendering#1004kala-moz wants to merge 3 commits intomozilla:mainfrom
kala-moz wants to merge 3 commits intomozilla:mainfrom
Conversation
Row template columns now only gets the columns for the version
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
- Coverage 96.46% 96.45% -0.01%
==========================================
Files 104 108 +4
Lines 3028 3050 +22
Branches 694 689 -5
==========================================
+ Hits 2921 2942 +21
- Misses 106 107 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmierz
reviewed
Feb 26, 2026
| * These are generic, version-agnostic replacements for the version-specific | ||
| * column types above. To support a new test version, | ||
| * extend CombinedResultsItemType in state.ts — | ||
| * no changes are needed in this section. |
Contributor
There was a problem hiding this comment.
Can you add some additional comments about how these types work, and why they exist?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BUG 2016285
This PR addresses the scalability and maintenance weaknesses of the current test version implementation.
First, an overall test version interface is created in src/common/testVersions/index.ts:
And each test version has their own file with their unique column configuration, for getting the average values, and rendering their specific columns in RevisionRow.tsx:
src/common/testVersions/mannWhitneysrc/common/testVersions/studentTTherefore, adding a new test version would only require creating a unique file for new test version.
example: /testVersions/welchNow, to get the columns for each test version, we only have to call the registry:
Rendering the columns in
RevisionRow.tsxis also simplified, removing the conditionals (if (testVersion === MANN_WHITNEY_U))This PR is part one of completing the refactor as we still need to expand the test version strategy to handle the unique test version components in the expanded rows. This will be completed in a follow-up PR.