Skip to content

feat: Add Sync policy#70

Open
bsmth wants to merge 5 commits intomozilla:mainfrom
bsmth:sync-policy
Open

feat: Add Sync policy#70
bsmth wants to merge 5 commits intomozilla:mainfrom
bsmth:sync-policy

Conversation

@bsmth
Copy link
Collaborator

@bsmth bsmth commented Mar 5, 2026

Description:

Adding Sync

Motivation:

Sync is incoming

For reviewers:

  • Check case sensitivity, such as:
Software\Policies\Mozilla\Firefox\Sync\bookmarks
Software\Policies\Mozilla\Firefox\Sync\Bookmarks

See also:

@bsmth bsmth requested a review from 1rneh March 5, 2026 13:17
"Sync": {
"Enabled": true,
"addresses": true,
"bookmarks": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having valid JSON here feels like a good thing, although this is likely an unrealistic example. Same with others, like:

{
  "policies": {
    "Sync": {
      "Enabled": true,
      "addresses": true,
      "bookmarks": true,
      "history": true,
      "openTabs": true,
      "passwords": true,
      "paymentMethods": true,
      "addons": true,
      "settings": true,
      "Locked": true
    }
  }
}

v

{
  "policies": {
    "Sync": {
      "Enabled": true | false,
      "addresses": true | false,
      "bookmarks": true | false,
      "history": true | false,
      "openTabs": true | false,
      "passwords": true | false,
      "paymentMethods": true | false,
      "addons": true | false,
      "settings": true | false,
      "Locked": true | false
    }
  }
}

Copy link

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the inconsistently capitalized properties form the JSDoc - a correction has landed.

I left a notes on the Sync description. If we follow the Acorn convention to not capitalize the first letter of "sync", we should update each occurrence in this document accordingly.

Aside from those comments, the docs look good to me.

@cadeyrn
Copy link

cadeyrn commented Mar 9, 2026

Is the policy exclusive to Firefox Enterprise? I can't see in the linked Bugzilla ticket that code has been added to regular Firefox, it only references a pull request for Firefox Enterprise.

If so: 1) Why? 2) It should be noted in the documentation, I guess.

bsmth and others added 2 commits March 9, 2026 13:40
Co-authored-by: Janika <92304290+1rneh@users.noreply.github.com>
@bsmth
Copy link
Collaborator Author

bsmth commented Mar 9, 2026

Is the policy exclusive to Firefox Enterprise? I can't see in the linked Bugzilla ticket that code has been added to regular Firefox, it only references a pull request for Firefox Enterprise.

If so: 1) Why? 2) It should be noted in the documentation, I guess.

Hi @cadeyrn thanks for flagging it.

  1. Currently it's in Firefox Enterprise only. It's needed for a specific use case in Enterprise, although there's a bug here tracking progress for landing it in Firefox -> https://bugzilla.mozilla.org/show_bug.cgi?id=2017722 we aim to have it supported everywhere eventually.
  2. I'll update the compat information so it's at least tracked in prose for now.

@bsmth bsmth marked this pull request as ready for review March 9, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants