Conversation
| "Sync": { | ||
| "Enabled": true, | ||
| "addresses": true, | ||
| "bookmarks": true, |
There was a problem hiding this comment.
Having valid JSON here feels like a good thing, although this is likely an unrealistic example. Same with others, like:
{
"policies": {
"Sync": {
"Enabled": true,
"addresses": true,
"bookmarks": true,
"history": true,
"openTabs": true,
"passwords": true,
"paymentMethods": true,
"addons": true,
"settings": true,
"Locked": true
}
}
}v
{
"policies": {
"Sync": {
"Enabled": true | false,
"addresses": true | false,
"bookmarks": true | false,
"history": true | false,
"openTabs": true | false,
"passwords": true | false,
"paymentMethods": true | false,
"addons": true | false,
"settings": true | false,
"Locked": true | false
}
}
}
1rneh
left a comment
There was a problem hiding this comment.
Thanks for pointing out the inconsistently capitalized properties form the JSDoc - a correction has landed.
I left a notes on the Sync description. If we follow the Acorn convention to not capitalize the first letter of "sync", we should update each occurrence in this document accordingly.
Aside from those comments, the docs look good to me.
|
Is the policy exclusive to Firefox Enterprise? I can't see in the linked Bugzilla ticket that code has been added to regular Firefox, it only references a pull request for Firefox Enterprise. If so: 1) Why? 2) It should be noted in the documentation, I guess. |
Co-authored-by: Janika <92304290+1rneh@users.noreply.github.com>
Hi @cadeyrn thanks for flagging it.
|
Description:
Adding Sync
Motivation:
Sync is incoming
For reviewers:
See also: