New rule to detect inactive patch authors#2426
Draft
benjaminmah wants to merge 20 commits intomozilla:masterfrom
Draft
New rule to detect inactive patch authors#2426benjaminmah wants to merge 20 commits intomozilla:masterfrom
benjaminmah wants to merge 20 commits intomozilla:masterfrom
Conversation
| rev_ids = {rev_id for bug in bugs.values() for rev_id in bug["rev_ids"]} | ||
| try: | ||
| inactive_authors = self._get_inactive_patch_authors(list(rev_ids)) | ||
| except Exception as e: |
Member
There was a problem hiding this comment.
I would avoid using Exception as the error-catching type where possible.
Contributor
Author
There was a problem hiding this comment.
Makes sense! I removed the try-except block here: 243515d. I made sure to do a dry-run and noticed that I did not encounter any errors, so I don't think the exception handler is necessary.
Comment on lines
+99
to
+100
| except Exception as e: | ||
| logging.error(f"Failed to abandon patch {rev_id} for bug {bugid}: {e}") |
Comment on lines
+122
to
+124
| except Exception as e: | ||
| logging.error(f"Error fetching revisions: {e}") | ||
| continue |
| user["unavailable_until"] = phab_user["attachments"][ | ||
| "availability" | ||
| ]["until"] | ||
| except Exception as e: |
suhaibmujahid
added
the
to-be-announced
Contributor
|
@suhaibmujahid I'm leaving this one for you since you started the review already. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1532.
Introduces a new rule to detect and unassign inactive patch authors on Phabricator.
If the patch is not already closed, it will be abandoned.
Checklist
to-be-announcedtag added if this is worth announcing