refactor(ads-client): make HttpCache generic over T: Hash + Into<Request>#7219
Draft
Almaju wants to merge 1 commit intomozilla:mainfrom
Draft
refactor(ads-client): make HttpCache generic over T: Hash + Into<Request>#7219Almaju wants to merge 1 commit intomozilla:mainfrom
Almaju wants to merge 1 commit intomozilla:mainfrom
Conversation
4037c83 to
7c5098c
Compare
…est> Move ads-specific cache key logic out of the generic HTTP cache layer. HttpCache is now HttpCache<T: Hash + Into<Request>> where T controls both hashing (for cache keys) and request construction. - Add RequestHash::new(&impl Hash) using DefaultHasher, remove From<&Request> that parsed JSON bodies and stripped context_id - Add url field to AdRequest with manual Hash impl (excludes context_id) and From<AdRequest> for Request - Make HttpCacheStore::lookup/store_with_ttl accept &RequestHash from caller - Add Environment::into_url(path) for building endpoint URLs - Derive Hash/Clone on AdPlacementRequest, AdContentCategory, IABContentTaxonomy
ab3b4c4 to
1fe3175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ads-specific cache key logic out of the generic HTTP cache layer. HttpCache is now HttpCache<T: Hash + Into> where T controls both hashing (for cache keys) and request construction.
Pull Request checklist
[ci full]to the PR title.