DRIVERS-3404 - Server selection deprioritization only for overload er…#1900
Merged
NoahStapp merged 4 commits intomongodb:masterfrom Feb 23, 2026
Merged
DRIVERS-3404 - Server selection deprioritization only for overload er…#1900NoahStapp merged 4 commits intomongodb:masterfrom
NoahStapp merged 4 commits intomongodb:masterfrom
Conversation
NoahStapp
requested review from
ShaneHarvey,
isabelatkinson and
jyemin
and removed request for
a team
Contributor
|
(Tagging in @tadjik1 for second implementation) |
tadjik1
reviewed
Feb 20, 2026
Member
|
Node 2nd implementation: mongodb/node-mongodb-native#4875 |
tadjik1
approved these changes
Feb 20, 2026
ShaneHarvey
reviewed
Feb 20, 2026
| For all other topologies, the server address on which the operation failed MUST be provided to the server selection | ||
| mechanism as a member of the deprioritized server address list only if the error is labelled with | ||
| `SystemOverloadedError`. All other retryable errors MUST NOT cause the server address to be added to the deprioritized | ||
| server address list. |
Member
There was a problem hiding this comment.
Could you add a brief rationale or Q&A section to explain this decision? IIUC it's so we don't change the behavior of retryable reads for non-overload errors because that might have unintended consequences for some operations (eg primaryPreferred reads).
ShaneHarvey
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rors on replica sets
Python implementation: mongodb/mongo-python-driver#2710.
Please complete the following before merging:
clusters).
DRIVERS-3404