MONGOCRYPT-432 Allow keyAltName in encryptedFieldsMap#1091
Open
mdb-ad wants to merge 58 commits intomongodb:masterfrom
Open
MONGOCRYPT-432 Allow keyAltName in encryptedFieldsMap#1091mdb-ad wants to merge 58 commits intomongodb:masterfrom
mdb-ad wants to merge 58 commits intomongodb:masterfrom
Conversation
mdb-ad
requested review from
vector-of-bool
and removed request for
vector-of-bool
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
reviewed
Feb 19, 2026
kevinAlbs
reviewed
Feb 20, 2026
kevinAlbs
reviewed
Feb 26, 2026
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
reviewed
Mar 5, 2026
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
approved these changes
Mar 10, 2026
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
With minor comments addressed, LGTM!
| * process. Instead, we'll do it ourselves here, if possible. | ||
| */ | ||
| static bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx) { | ||
| bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx) { |
Contributor
There was a problem hiding this comment.
Suggest restoring static since this is no-longer called outside of mongocrypt-ctx-encrypt.c:
Suggested change
| bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx) { | |
| static bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx) { |
| const char *name); | ||
|
|
||
| void _bson_value_from_string(const char *string, bson_value_t *value); | ||
| bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx); |
Contributor
There was a problem hiding this comment.
Suggested change
| bool _try_run_csfle_marking(mongocrypt_ctx_t *ctx); |
| @@ -15,13 +15,15 @@ | |||
| */ | |||
|
|
|||
| #include <bson/bson.h> | |||
Contributor
There was a problem hiding this comment.
Revert no-longer-needed changes to mongocrypt-ctx.c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Adds
keyAltNametokeyIdclient-side translation to libmongocrypt that allows users to specify human-readablekeyAltNamestrings instead of binary key IDs.Implementation
Whenever
encryptionInformationis appended to at outgoing command, libmongocrypt looks through the encrypted fields forkeyAltNamefields and translates them tokeyId.Testing
Tested on the C driver with spec test: https://spruce.mongodb.com/version/697803dbc0c964000764d2a4/