fix: Add default value to _print function parameter#134
Merged
wangxingjun778 merged 2 commits intomodelscope:mainfrom Apr 1, 2026
Merged
fix: Add default value to _print function parameter#134wangxingjun778 merged 2 commits intomodelscope:mainfrom
wangxingjun778 merged 2 commits intomodelscope:mainfrom
Conversation
…essage parameter defaults to an empty string
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _print utility function in web_launcher.py to allow calling it without arguments by setting a default value for the msg parameter. Feedback suggests adding an explicit -> None return type hint to the function signature to improve type safety and maintain consistency with the rest of the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_printfunction to have a default empty string value formsgparameter_print()without arguments would fail at runtimeProblem
The
_printfunction inweb_launcher.pyrequired amsgparameter with no default value:sirchmunk/src/sirchmunk/cli/web_launcher.py
Lines 43 to 45 in d7a7ec9
But it was being called without arguments in some code paths, causing the application to crash on startup.
sirchmunk/src/sirchmunk/cli/web_launcher.py
Lines 605 to 614 in d7a7ec9
Solution
Added default empty string to the parameter:
Test plan
_print()can now be called without arguments