feat: support exclude_file_patterns option#25
Conversation
Summary of ChangesHello @imeoer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the model fetching mechanism and improving progress reporting within the system. It includes a significant update of Go module dependencies to leverage newer features and maintain security. Key functional changes involve modifying model artifact handling to provide total layer counts, which is then utilized by an improved progress reporting system. Additionally, it introduces support for a Dragonfly endpoint, enabling more efficient and distributed model fetching. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for a Dragonfly endpoint for model fetching and significantly refactors the model artifact handling and progress reporting logic. The dependency updates in go.mod and go.sum bring in newer versions of many packages, which is good for security and compatibility. The changes to pkg/service/model.go, pkg/service/puller.go, and pkg/status/hook.go aim to provide more accurate progress tracking. My review focuses on ensuring the new progress reporting logic is robust. I've identified a few areas for improvement to correctly handle progress totals for filtered downloads and to account for potential duplicate layers in model artifacts, which could affect the accuracy of the progress display.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Signed-off-by: imeoer <yansong.ys@antgroup.com>
Reference: modelpack#17 Signed-off-by: imeoer <yansong.ys@antgroup.com>
50de3e6 to
897e414
Compare
And add coverage threshold check Signed-off-by: imeoer <yansong.ys@antgroup.com>
This pull request introduces significant improvements to the code coverage workflow, updates dependencies for better compatibility and security, and adds new unit tests for the client package. The coverage workflow is now split to support posting coverage comments on PRs from forks, and includes stricter threshold enforcement for overall and changed-line coverage. Dependency versions in
go.modhave been updated to their latest releases. Additionally, new tests have been added to the client package to improve reliability.CI/CD and Coverage Workflow Enhancements:
.github/workflows/coverage-comment.ymlto post coverage reports as PR comments after the coverage workflow completes, allowing coverage comments on PRs from forks by running in the base branch context..github/workflows/coverage.ymlto enforce total and diff coverage thresholds, generate detailed markdown reports, upload artifacts for comment workflow, and use a CI-friendly coverage command. [1] [2] [3] [4]Dependency Updates:
go.modto their latest versions, includingmodelpack/modctl,prometheus/client_golang,go-git/go-git/v5,grpc-gateway,go.opentelemetry.io/otel, and others for improved stability and compatibility. [1] [2] [3] [4]Testing Improvements:
pkg/client/client_test.goto cover client creation, error handling, and payload dumping, increasing test reliability and coverage.test-coverage-citarget inMakefilefor CI-friendly coverage runs, excludingpkg/serverand using-coverpkgfor accurate cross-package coverage. [1] [2]