Skip to content

Initialize pointer variables to NULL in ModelicaInternal.c #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DagBruck wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −15
Open

Initialize pointer variables to NULL in ModelicaInternal.c #4783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87f9ae
Initialize pointer variables to NULL in ModelicaInternal.c
DagBruck Apr 29, 2026
9ac5e09
added changelog entry
StephanZiegler Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions Modelica/Resources/C-Sources/ModelicaInternal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
*/

/* Changelog:
Apr. 29, 2026: by Dag Brueck, Dassault Systemes AB
Initialize pointer variables to NULL
(ticket #4783)
Oct. 20, 2024: by Thomas Beutlich
Removed legacy behaviour in ModelicaInternal_stat for
MSVC Visual Studio >= 2015 (ticket #4473)
Expand Down Expand Up @@ -755,7 +758,7 @@ _Ret_z_ const char* ModelicaInternal_fullPathName(_In_z_ const char* name) {

_Ret_z_ const char* ModelicaInternal_temporaryFileName(void) {
/* Get full path name of a temporary file name which does not exist */
char* fullName;
char* fullName = NULL;

char* tempName = tmpnam(NULL);
if (tempName == NULL) {
Expand Down Expand Up @@ -834,7 +837,7 @@ static void G2_FUNCNAME(ModelicaInternal_deleteCS)(void) {
#endif

static void CacheFileForReading(FILE* fp, const char* fileName, int lineNumber, char* buf, int bufLen) {
FileCache* fv;
FileCache* fv = NULL;
size_t len;
if (fileName == NULL) {
/* Do not add, close file */
Expand Down Expand Up @@ -878,7 +881,7 @@ static void CacheFileForReading(FILE* fp, const char* fileName, int lineNumber,
}

static void CloseCachedFile(const char* fileName) {
FileCache* fv;
FileCache* fv = NULL;
size_t len = strlen(fileName);
MUTEX_LOCK();
HASH_FIND(hh, fileCache, fileName, (unsigned)len, fv);
Expand All @@ -896,8 +899,8 @@ static void CloseCachedFile(const char* fileName) {

static FILE* ModelicaStreams_openFileForReading(const char* fileName, int lineNumber, int* lineNumberOffset, char** buf, int* bufLen) {
/* Open text file for reading */
FILE* fp;
FileCache* fv;
FILE* fp = NULL;
FileCache* fv = NULL;
size_t len = strlen(fileName);
*lineNumberOffset = 0;
*buf = NULL;
Expand Down Expand Up @@ -954,7 +957,7 @@ void ModelicaStreams_closeFile(_In_z_ const char* fileName) {

static FILE* ModelicaStreams_openFileForWriting(const char* fileName) {
/* Open text file for writing (with append) */
FILE* fp;
FILE* fp = NULL;

/* Check fileName */
if ( fileName[0] == '\0' ) {
Expand All @@ -973,8 +976,8 @@ static FILE* ModelicaStreams_openFileForWriting(const char* fileName) {
}

static int readLine(_In_ char** buf, _In_ int* bufLen, _In_ FILE* fp) {
char* offset;
int oldBufLen;
char* offset = NULL;
int oldBufLen = 0;

if (fgets(*buf, *bufLen, fp) == NULL) {
return EOF;
Expand Down Expand Up @@ -1041,7 +1044,7 @@ int ModelicaInternal_countLines(_In_z_ const char* fileName) {
/* Get number of lines of a file */
int lineNumberOffset;
int bufLen;
char* buf;
char* buf = NULL;
int c;
int nLines = 0;
int start_of_line = 1;
Expand All @@ -1068,9 +1071,9 @@ void ModelicaInternal_readFile(_In_z_ const char* fileName,
/* Read file into string vector string[nLines] */
int lineNumberOffset;
int bufLen;
char* buf;
char* buf = NULL;
FILE* fp = ModelicaStreams_openFileForReading(fileName, 0, &lineNumberOffset, &buf, &bufLen);
char* line;
char* line = NULL;
size_t iLines = 1;

if (buf == NULL) {
Expand Down Expand Up @@ -1184,8 +1187,8 @@ void ModelicaInternal_chdir(_In_z_ const char* directoryName) {
}

_Ret_z_ const char* ModelicaInternal_getcwd(int dummy) {
const char* cwd;
char* directory;
const char* cwd = NULL;
char* directory = NULL;

#if defined(__WATCOMC__) || defined(__BORLANDC__) || defined(_POSIX_) || defined(__GNUC__)
char localbuf[BUFFER_LENGTH];
Expand All @@ -1212,9 +1215,9 @@ _Ret_z_ const char* ModelicaInternal_getcwd(int dummy) {
void ModelicaInternal_getenv(_In_z_ const char* name, int convertToSlash,
_Out_ const char** content, _Out_ int* exist) {
/* Get content of environment variable */
char* result;
char* result = NULL;
#if defined(_MSC_VER) && _MSC_VER >= 1400
char* value;
char* value = NULL;
size_t len = 0;
errno_t err = _dupenv_s(&value, &len, name);
if (err) {
Expand Down