Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 80.71% 80.74% +0.03%
==========================================
Files 41 41
Lines 3920 3921 +1
==========================================
+ Hits 3164 3166 +2
+ Misses 756 755 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix warning in
tests/test_emissions_tracker.py::TestCarbonTracker::test_carbon_tracker_TWO_GPU_PRIVATE_INFRA_CANADA:Motivation and Context
It's only a warning but it looks like an error.
The thread warning was caused by the background GPU utilization sampler assuming every GPU detail dict contains gpu_index. I fixed that in emissions_tracker.py:982 by falling back to the position in the returned GPU details list when the key is missing, which keeps subset filtering working and avoids the KeyError.
How Has This Been Tested?
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.