load metallib not only as resource but in root of a bundle#2885
Open
gin66 wants to merge 1 commit intoml-explore:mainfrom
Open
load metallib not only as resource but in root of a bundle#2885gin66 wants to merge 1 commit intoml-explore:mainfrom
gin66 wants to merge 1 commit intoml-explore:mainfrom
Conversation
4 tasks
Contributor
|
I think we should hold onto this until we discuss on the mlx-swift side. I am concerned that this works around a build issue in the metal builder plugin -- perhaps we should just figure out how to get that to produce the correct path. See also ml-explore/mlx-swift#313 |
Author
|
I would appreciate to get this implemented. It has no negative side effects and the code after my comment could be kept, even though I wonder, if this is a leftover of an older code basis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is in relation to mlx-swift. MetalCompilerPlugin does not generate a resource, but stores the lib in the bundle root. This patch adds bundle root to the search locations for the default.metallib.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes