Conversation
handle_firstauth() already failed, so this should be consistent.
This is ed25519 specific, so name it to match
This represents a RFC4251 mpint type, like a BinString but with padding for top-bit-set, and other padding 0x00 bytes removed. Replaces existing handling for kex and rsa, can also be used by other protocol formats like ecdsa.
This is using rc ecdsa crate versions which pulls in various duplicate crate implementations such as sha2, adding bloat. Hopefully it won't be too long until versions can be deduplicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is using rc ecdsa crate versions which pulls in various duplicate
crate implementations such as sha2, adding bloat.
Hopefully it won't be too long until versions can be deduplicated.