Signing JWT based on the default keyId. Currently, it signs based on…#1612
Open
DmytriE wants to merge 1 commit intomitreid-connect:masterfrom
Open
Signing JWT based on the default keyId. Currently, it signs based on…#1612DmytriE wants to merge 1 commit intomitreid-connect:masterfrom
DmytriE wants to merge 1 commit intomitreid-connect:masterfrom
Conversation
…the first key which has the desired algorithm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes looks to see if there is a default key ID defined. If so, then we should grab the key based on the key ID from the keystore. However, the current implementation iterates through a list of keys in a jwks keystore looking for the first which has the desired algorithm. This works if you have a single key which uses that algorithm. If we would like a rolling key situation this fails and cannot be relied upon.