Fix issue #43: Export lexical variable getter and setter blocks from core#85
Open
SurbhiAgarwal1 wants to merge 2 commits intomit-cml:mainfrom
Open
Fix issue #43: Export lexical variable getter and setter blocks from core#85SurbhiAgarwal1 wants to merge 2 commits intomit-cml:mainfrom
SurbhiAgarwal1 wants to merge 2 commits intomit-cml:mainfrom
Conversation
…s from core - Export lexical_variable_get and lexical_variable_set block definitions - Add blocks to core.js imports so they're available when importing core - Add idempotent registration guard to prevent duplicate registration - Export blocks from LexicalVariablesPlugin class for easy access - Update README with documentation about exported blocks - All VariableGetSet tests pass (4/4) The blocks are now automatically registered when importing either the core or main entry point, and are accessible via exports for developers who need to customize or override them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43
This PR exports the
lexical_variable_getandlexical_variable_setblock definitions from the core module, making them available to developers who import the plugin.Tasks Completed:
lexical_variable_getblock definition fromvariable-get-set.jslexical_variable_setblock definition fromvariable-get-set.jscore.jsto ensure automatic registrationLexicalVariablesPluginclassindex.jsentry pointWhy This Change?
The core fields (
FieldGlobalFlydownandFieldParameterFlydown) create XML that references these blocks. Previously, when developers imported only the core module, these blocks weren't available, causing issues. Now they're automatically registered and accessible.Testing
Usage Examples