fix lib exports and add prefixes to export type names#75
Open
fix lib exports and add prefixes to export type names#75
Conversation
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds module-specific prefixes to exported type names (e.g., SwapOptions → StableswapSwapOptions, DepositOptions → DexV2DepositOptions) to avoid naming conflicts, and broadens index.ts exports from selective to wildcard re-exports for several modules. It also removes unused networkEnv and dexVersion fields from multiple classes.
Changes:
- Prefixed all exported type names in
dex.ts,dex-v2.ts,stableswap.ts, andlbe-v2/type.tswith their module identifier (DexV1, DexV2, Stableswap, LbeV2) - Changed
index.tsfrom selective exports toexport *forstableswap,dao,lbe-v2/type, andtypes/factory - Removed unused
networkEnv,networkEnv, anddexVersionprivate fields fromDex,DexV2,Stableswap, andLbeV2classes
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Broadened exports to wildcard for several modules |
| src/dex.ts | Prefixed types with DexV1, removed unused fields |
| src/dex-v2.ts | Prefixed types with DexV2, removed unused fields |
| src/stableswap.ts | Prefixed types with Stableswap, removed unused fields, added local StableswapCustomReceiver type |
| src/lbe-v2/type.ts | Prefixed types with LbeV2 |
| src/lbe-v2/lbe-v2.ts | Updated imports/usages, removed unused fields |
| src/lbe-v2/validation.ts | Updated imports/usages to match renamed types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Nguyen Le Vu Long <vulongvn98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.