Merged
Conversation
Delete Apache Commons Logging config from microsphere-logging-parent/pom.xml: the <apache-commons-logging.version> property and the commons-logging dependency were removed. Logging dependencies remain managed via the existing SLF4J/Log4J entries in the parent POM.
Remove the legacy Log4j 1.x property and dependency from microsphere-logging-parent POM (log4j.version and log4j:log4j 1.2.17). Update comment to reflect Log4j2 usage and keep Log4j2 (log4j-api) dependency. This drops support for the old Log4j 1.x artifact in favor of Log4j2.
🤖 Augment PR SummarySummary: Simplifies the 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| <version>${apache-commons-logging.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- Slf4j --> |
There was a problem hiding this comment.
After removing commons-logging:commons-logging and log4j:log4j from this parent’s dependencyManagement, modules like microsphere-logging-commons still declare those dependencies without explicit <version>s, which will fail Maven resolution unless the imported microsphere-java-dependencies BOM manages them.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Add a new property <log4j.version>1.2.17</log4j.version> and include the log4j:log4j dependency using that version in microsphere-logging-parent/pom.xml. This ensures legacy Log4j 1.2.17 is available for modules that require compatibility with older logging integrations.
Correct the <name> element in microsphere-log4j2/pom.xml from 'Microsphere :: Logging :: Logj4' to 'Microsphere :: Logging :: Log4j2' to fix a typo and align the module name with the project. No functional changes.
Update .github/workflows/maven-build.yml: remove 'main' from pull_request branches (PRs now trigger only for dev and release) and expand the Java test matrix to include Java 8 and 11 alongside 17, 21 and 25 to broaden CI coverage for older JDKs.
Update .github/workflows/maven-publish.yml: change the default revision from '2.0.0-SNAPSHOT' to '1.0.0-SNAPSHOT' and switch the Actions Java runtime from 17 to 11 (temurin). Aligns the workflow with the intended default publish version and Java compatibility.
Normalize log4j section comments in microsphere-logging-commons/pom.xml: change "Log4j 1.x" to "Log4j" and "Log4j 2.x" to "Log4j2". No dependency or functional changes—just comment text for clarity.
Introduce a new microsphere-log4j module providing Log4j support: add implementation classes (Log4j2Logger, Log4jLoggerFactory, Log4jLogging, LoggerUtils), service loader entries, test suite and a test log4j.xml. Integrate the module into the build by updating root pom (add module, adjust revision/java.version), include the module in microsphere-logging-dependencies and examples poms, and add Log4j dependencies to README and examples. Also update microsphere-logging-parent: bump junit-jupiter.version and add Java 8/17+ profiles to manage compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the logging dependencies in the
microsphere-logging-parentproject by removing outdated and redundant logging libraries from the Maven configuration. The focus is now on using more modern logging frameworks.Dependency cleanup:
pom.xml, reducing unnecessary transitive dependencies. [1] [2]