Fix panic for rest properties in catch binding when targeting ES2017

[Copilot]

visitCatchClause in the object rest/spread transformer used a bitwise AND (Kind & KindSyntaxList != 0) to check the result of FlattenDestructuringBinding. Since KindSyntaxList (344) is not a power of 2, this incorrectly matched VariableDeclaration nodes, causing a type assertion panic on AsSyntaxList().

// panics with: interface conversion: ast.nodeData is *ast.VariableDeclaration, not *ast.SyntaxList
try {} catch ({ ...rest }) {}

• Fix: Kind & KindSyntaxList != 0 → Kind == KindSyntaxList
• Add regression test catchClauseRestProperties.ts

[jakebailey]

Oops, that's a typo

[Copilot]

Pull request overview

Fixes a panic in the object rest/spread transformer when flattening destructuring bindings in catch clauses by correcting an invalid bitwise kind check (which could misclassify a VariableDeclaration as a SyntaxList).

Changes:

• Fix visitCatchClause to check visitedBindings.Kind == ast.KindSyntaxList instead of using Kind & KindSyntaxList != 0.
• Add a regression compiler test covering catch ({ ...rest }) {} with @target: es2017.
• Add new reference baselines for JS emit, types, symbols, and diagnostics for the new test.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
testdata/tests/cases/compiler/catchClauseRestProperties.ts	Adds a regression test that previously triggered a panic in the transformer.
testdata/baselines/reference/compiler/catchClauseRestProperties.types	Reference types baseline for the new test.
testdata/baselines/reference/compiler/catchClauseRestProperties.symbols	Reference symbols baseline for the new test.
testdata/baselines/reference/compiler/catchClauseRestProperties.js	Reference JS emit baseline verifying object-rest downleveling in catch binding.
testdata/baselines/reference/compiler/catchClauseRestProperties.errors.txt	Reference diagnostics baseline ensuring compilation reports the expected error without panicking.
internal/transformers/estransforms/objectrestspread.go	Fixes the kind check to avoid calling AsSyntaxList() on non-SyntaxList nodes.