Fix panic on anonymous class declaration with decorator targeting ES2022#3926
Draft
Copilot wants to merge 2 commits into
Draft
Fix panic on anonymous class declaration with decorator targeting ES2022#3926Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ng ES2022 Handle the case where an anonymous class declaration (not export default) has decorators. Instead of asserting that a name must exist, emit the IIFE as an expression statement. Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/a8b3bbaf-a8f1-4207-973a-1001c1b3537d Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tsgo panic with anonymous class declaration and member decorator
Fix panic on anonymous class declaration with decorator targeting ES2022
May 16, 2026
jakebailey
reviewed
May 16, 2026
Comment on lines
-1066
to
-1067
| } else { | ||
| debug.Assert(classNode.Name() != nil, "A class declaration that is not a default export must have a name.") |
Member
There was a problem hiding this comment.
@copilot The original code said:
Debug.assertIsDefined(node.name, "A class declaration that is not a default export must have a name.");Removing an assert that the old code does not make sense unless you can prove that the old compiler also crashes on this input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visitClassDeclarationin the ES decorator transformer assumed all non-export defaultclass declarations have names, hitting a debug assertion panic for anonymous decorated classes like:export defaultclass declarations that emits the transformed IIFE as an expression statement ((() => { ... })();) rather than attempting a variable bindinganonymousClassDecoratorEs2022.ts