Align declaration emit printer options with strada

[Copilot]

.d.ts.map files incorrectly include sourcesContent when inlineSources is enabled, and the declaration printer options bag was generally out of date with strada's emitDeclarationFileOrBundle.

• Update the full declaration printer options in emitDeclarationFile to match strada's emitDeclarationFileOrBundle (emitter.ts:924-936):
  • NoEmitHelpers hardcoded to true (declarations never need helpers)
  • Added Target from options.GetEmitScriptTarget()
  • SourceMap now gated on e.emitOnly != EmitOnlyForcedDts (matching strada's BuilderSignature guard)
  • InlineSources excluded (per strada)
  • Added OmitBraceSourceMapPositions: true
  • Added NYI comments for Module, ModuleResolution, ExtendedDiagnostics
• Add compiler test declarationMapInlineSourcesContent covering the inlineSources + declarationMap case

[jakebailey]

@weswigham Surprised we didn't include maps on d.ts files but it does seem that we didn't before.

[Copilot]

Pull request overview

Aligns tsgo’s declaration map emission behavior with the TypeScript compiler by ensuring .d.ts.map does not embed sourcesContent when inlineSources is enabled.

Changes:

• Updates declaration emit printer options to avoid propagating inlineSources into .d.ts.map generation.
• Adds a new compiler test case covering inlineSources + declarationMap to ensure .d.ts.map omits sourcesContent.
• Adds/updates corresponding reference baselines for the new test.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
testdata/tests/cases/compiler/declarationMapInlineSourcesContent.ts	New compiler test exercising inlineSources with declarationMap.
testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.types	Baseline for type output of the new test.
testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.symbols	Baseline for symbol output of the new test.
testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.sourcemap.txt	Baseline verifying sourcemap details, including absence of sourcesContent for .d.ts.map.
testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.js.map	Baseline JSON for .js.map and .d.ts.map outputs.
testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.js	Baseline emitted JS + .d.ts output.
internal/compiler/emitter.go	Adjusts declaration emit printer options related to inline sourcemap/source content behavior.

Files not reviewed (1)

• testdata/baselines/reference/compiler/declarationMapInlineSourcesContent.js: Language not supported

[jakebailey]

The original code says:

sourceMap: emitOnly !== EmitOnly.BuilderSignature && compilerOptions.declarationMap,
inlineSourceMap: compilerOptions.inlineSourceMap,

So this is correct, but the doc needs updating and maybe the BuilderSignature thing needs to be investigated.

@copilot

[Copilot]

Updated the comment in f2e73f3 to say // Explicitly do not passthru \inlineSources`instead of referencing both inline options, sinceinlineSourceMap` is correctly passed through.

[weswigham]

These options look a bit off in general - NoEmitHelpers, for example is... yeah.

Can we update the whole options bag while we're here to

	printerOptions := printer.PrinterOptions{
		RemoveComments: options.RemoveComments.IsTrue(),
		NewLine:        options.NewLine,
		NoEmitHelpers:  true,
		// Module: 			   options.Module, // NYI
		// ModuleResolution:	options.ModuleResolution, // NYI
		Target:          options.GetEmitScriptTarget(),
		SourceMap:       e.emitOnly != EmitOnlyForcedDts && options.DeclarationMap.IsTrue(),
		InlineSourceMap: options.InlineSourceMap.IsTrue(),
		// InlineSources:       options.InlineSources.IsTrue(), // ignored, per strada
		// ExtendedDiagnostics: options.ExtendedDiagnostics.IsTrue(), // NYI
		OnlyPrintJSDocStyle:         true,
		OmitBraceSourceMapPositions: true,
	}

to more faithfully match strada?

[weswigham]

(Mostly because I imagine this options object first got ported without most of these implemented)

[jakebailey]

@copilot Make it match and see if it works, see the above for what to copy

[Copilot]

Updated the full options bag to match strada in f8583b5. Changes: NoEmitHelpers: true (hardcoded), added Target, SourceMap now guarded with e.emitOnly != EmitOnlyForcedDts, added OmitBraceSourceMapPositions: true, and NYI comments for Module, ModuleResolution, ExtendedDiagnostics. The declarationMaps submodule test baseline diff got smaller as a result.