add static property duplicate name check #3804
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #3484 by restoring TS2699 diagnostics for static class members that conflict with built-in Function properties when useDefineForClassFields is false, aligning tsgo’s output with expected baselines and removing an obsolete triaged diff.
Changes:
- Add a checker pass during class-like declaration checking to report TS2699 for conflicting static member names (e.g.
name,length,caller,arguments,prototype) under the relevant compiler option conditions. - Update the conformance error baseline for
staticPropertyNameConflicts(...,usedefineforclassfields=false)to include the restored TS2699 errors. - Remove the now-unneeded triaged
.diffbaseline for the same conformance case.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/checker/checker.go | Adds a class-like static member conflict check intended to restore TS2699 for built-in Function property name collisions. |
| testdata/baselines/reference/submodule/conformance/staticPropertyNameConflicts(target=es2015,usedefineforclassfields=false).errors.txt | Updates expected errors to reflect restored TS2699 diagnostics (now matching upstream expectations for this configuration). |
| testdata/baselines/reference/submoduleTriaged/conformance/staticPropertyNameConflicts(target=es2015,usedefineforclassfields=false).errors.txt.diff | Removes an obsolete triaged diff baseline because the behavior is no longer divergent. |
andrewbranch
requested changes
May 12, 2026
andrewbranch
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3484