Skip to content

chore(ci): add path filters and PR/merge_group triggers to kapinger workflow#2110

Merged
nddq merged 1 commit intomainfrom
chore/kapinger-ci-triggers
Mar 27, 2026
Merged

chore(ci): add path filters and PR/merge_group triggers to kapinger workflow#2110
nddq merged 1 commit intomainfrom
chore/kapinger-ci-triggers

Conversation

@nddq
Copy link
Copy Markdown
Member

@nddq nddq commented Mar 13, 2026

Description

The kapinger workflow runs on every push to main regardless of whether kapinger files changed, and has no pull_request or merge_group triggers so changes aren't validated before merge.

Add paths filters scoped to hack/tools/kapinger/** and the workflow file itself, pull_request and merge_group triggers, tags trigger for releases, and explicit permissions block.

Related Issue

N/A

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...).
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

CI-only change — no manual testing needed.

Additional Notes

Split out from #2096 per review feedback.

@nddq nddq requested a review from a team as a code owner March 13, 2026 12:58
@nddq nddq requested review from nairashu and snguyen64 March 13, 2026 12:58
@nddq
Copy link
Copy Markdown
Member Author

nddq commented Mar 13, 2026

CI is failing as expected, need #2096 to go in first

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 13, 2026

Retina Code Coverage Report

Total coverage no change

Increased diff

Impacted Files Coverage
pkg/controllers/daemon/namespace/namespace_controller.go 76.24% ... 78.46% (2.22%) ⬆️

@nddq nddq force-pushed the chore/kapinger-ci-triggers branch from a2d98ff to 2000422 Compare March 19, 2026 15:44
…orkflow

The kapinger workflow previously ran on every push to main regardless of
whether kapinger files changed. Add path filters, pull_request and
merge_group triggers so CI validates kapinger changes before merge, and
skip unnecessary runs when unrelated files change.

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
@nddq nddq force-pushed the chore/kapinger-ci-triggers branch from 2000422 to 6517f2d Compare March 19, 2026 15:48
@nddq nddq enabled auto-merge March 20, 2026 01:01
@nddq nddq requested a review from matmerr March 20, 2026 01:01
@nddq nddq added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit a0b7220 Mar 27, 2026
34 checks passed
@nddq nddq deleted the chore/kapinger-ci-triggers branch March 27, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants