fix: add guard clause for MetricsInterval#2084
Merged
nddq merged 4 commits intomicrosoft:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
uuditmisra
force-pushed
the
fix-ticker-panic
branch
3 times, most recently
from
c139c30 to
981eee8
Compare
uuditmisra
changed the title
uuditmisra
force-pushed
the
fix-ticker-panic
branch
from
981eee8 to
634b44f
Compare
nddq
requested changes
Mar 4, 2026
Member
nddq
left a comment
nddq
left a comment
There was a problem hiding this comment.
The approach is sound overall, just need to move the fix to the correct position to it will apply to all plugins. That's said, might be a good idea to include the default metricsInterval in the Helm values as well for this PR.
Signed-off-by: Uudit Misra <uuditmisra@gmail.com>
uuditmisra
force-pushed
the
fix-ticker-panic
branch
from
4e004bc to
d9f6bc7
Compare
Signed-off-by: Uudit Misra <uuditmisra@gmail.com>
Signed-off-by: Uudit Misra <uuditmisra@gmail.com>
nddq
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent panic: runtime error: invalid duration when MetricsInterval is missing or set to 0. Added a default fallback to 10s and a warning log to inform the user of the configuration issue.
Closes #2029
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.