fix(electron): enable screenshot-on-failure for Electron apps#40058
Open
Glisa060 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(electron): enable screenshot-on-failure for Electron apps#40058Glisa060 wants to merge 2 commits intomicrosoft:mainfrom
Glisa060 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Track Electron contexts in Playwright._allContexts() so the test runner's SnapshotRecorder can capture screenshots from Electron windows on test failure.
Verifies that screenshot: 'only-on-failure' produces test-failed-1.png when an Electron test fails.
|
@Glisa060 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playwright._allContexts()so the test runner'sSnapshotRecordercan capture screenshots from Electron windows on test failurerunAfterCreateBrowserContextinstrumentation hook for Electron contexts to enable tracing/artifact collectionscreenshot: 'only-on-failure'producestest-failed-1.pngfor Electron apps