flowey: skip copy when source and destination paths are identical#3013
Merged
benhillis merged 1 commit intomicrosoft:mainfrom Mar 17, 2026
Merged
flowey: skip copy when source and destination paths are identical#3013benhillis merged 1 commit intomicrosoft:mainfrom
benhillis merged 1 commit intomicrosoft:mainfrom
Conversation
smalis-msft
previously approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows Flowey failure where the linux test kernel/initrd “magic path” initialization step could end up attempting to copy a file onto itself (triggering OS error 32) when dependencies are already installed directly into the destination directory.
Changes:
- Avoid copying
initrdwhen the resolved source path equals the computed destination path. - Avoid copying the kernel (
vmlinux/Image) when the resolved source path equals the computed destination path.
You can also share your feedback on Copilot code review. Take the survey.
On Windows, the closed-source NuGet package installs files directly into
the magic path (oss/.packages/underhill-deps-private/{arch}/), so the
copy step was trying to copy files onto themselves, causing OS error 32.
benhillis
force-pushed
the
avoid_copy_to_self
branch
from
ad6fbf8 to
63217da
Compare
smalis-msft
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the closed-source NuGet package installs files directly into the magic path (oss/.packages/underhill-deps-private/{arch}/), so the copy step was trying to copy files onto themselves, causing OS error 32.