sidecar: vp offline diagnostic logging#2967
Merged
sunilmut merged 1 commit intomicrosoft:mainfrom Mar 17, 2026
Merged
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves VP startup diagnostics in OpenHCL when a VP’s target CPU is offline, by distinguishing the “offline CPU but no sidecar available” case from the “offline CPU handled via sidecar” path to avoid misleading sidecar-related behavior/logging.
Changes:
- Add
sidecar_enabled()plumbing fromHcl→UhProcessorBox. - In VP spawn logic, bail out early if the CPU is offline and sidecar support is not enabled (instead of proceeding into sidecar startup paths).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openhcl/virt_mshv_vtl/src/lib.rs | Exposes UhProcessorBox::sidecar_enabled() to query sidecar availability. |
| openhcl/underhill_core/src/vp.rs | Adds an early error path for offline CPUs when sidecar isn’t enabled. |
| openhcl/hcl/src/ioctl.rs | Adds Hcl::sidecar_enabled() based on whether a SidecarClient is present. |
| // The CPU is not online, so this should be a sidecar VP. Run the VP | ||
| // No sidecar and the CPU is offline; this VP cannot run. | ||
| if !self.vp.sidecar_enabled() { | ||
| anyhow::bail!("cpu {} is offline", self.cpu); |
smalis-msft
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sidecar is not enabled, VP startup should indicate proper logging to as not confuse with sidecar.