Skip to content

Fix: preserve Python variable name for returned input aliases#2788

Open
Aniketsy wants to merge 3 commits intomicrosoft:mainfrom
Aniketsy:fix-2714
Open

Fix: preserve Python variable name for returned input aliases#2788
Aniketsy wants to merge 3 commits intomicrosoft:mainfrom
Aniketsy:fix-2714

Conversation

@Aniketsy
Copy link
Contributor

@Aniketsy Aniketsy commented Feb 2, 2026

@justinchuby
Copy link
Collaborator

@Aniketsy thanks, could you resolve the merge conflicts?

@Aniketsy Aniketsy marked this pull request as draft February 3, 2026 04:53
@Aniketsy
Copy link
Contributor Author

Aniketsy commented Feb 3, 2026

Sorry, I'll fix this

@Aniketsy Aniketsy marked this pull request as ready for review February 3, 2026 10:09
@Aniketsy
Copy link
Contributor Author

Aniketsy commented Feb 3, 2026

@justinchuby please review these, when you get a chance, I've fixed conflicts.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.45%. Comparing base (a9cb429) to head (90b45cc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/_internal/converter.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2788      +/-   ##
==========================================
- Coverage   70.45%   70.45%   -0.01%     
==========================================
  Files         228      228              
  Lines       27177    27180       +3     
  Branches     2734     2735       +1     
==========================================
+ Hits        19148    19150       +2     
  Misses       7092     7092              
- Partials      937      938       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants