Add op test for torch.unique_consecutive#2742
Open
cnaples79 wants to merge 1 commit intomicrosoft:mainfrom
Open
Add op test for torch.unique_consecutive#2742cnaples79 wants to merge 1 commit intomicrosoft:mainfrom
cnaples79 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Added OpInfo-based test for torch.unique_consecutive operator: - Created sample_inputs_unique_consecutive function in extra_opinfo.py that reuses common_methods_invocations.sample_inputs_unique - Added OpInfo entry for ops.aten.unique_consecutive with integral_types - Added TorchLibOpInfo entry in ops_test_data.py Fixes microsoft#2695
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 226 226
Lines 27388 27388
Branches 2781 2781
=======================================
Hits 19198 19198
Misses 7234 7234
Partials 956 956 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thanks - looks like there are some errors |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds OpInfo-based test coverage for the torch.unique_consecutive operator, addressing issue #2695. The test reuses PyTorch's standard test infrastructure and follows the established pattern used by other unique operators in the codebase.
Key changes:
- Added
sample_inputs_unique_consecutivefunction to filter test samples to only includedim=Nonecases (matching implementation limitations) - Added
OpInfoentry forops.aten.unique_consecutivewith integral dtypes configuration - Registered the operator in
TorchLibOpInfoto enable the test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/function_libs/torch_lib/extra_opinfo.py | Adds sample input generator and OpInfo configuration for unique_consecutive operator |
| tests/function_libs/torch_lib/ops_test_data.py | Registers the operator in TorchLibOpInfo test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.unique_consecutiveoperatorChanges
sample_inputs_unique_consecutivefunction inextra_opinfo.pythat filters samples fromcommon_methods_invocations.sample_inputs_uniqueto only include cases withdim=None(as the implementation has limited dim support)OpInfoentry forops.aten.unique_consecutivewithintegral_typesdtypes (matching the implementation which only supports int32/int64)TorchLibOpInfoentry inops_test_data.pyto enable the testTesting
The test follows the same pattern as other unique operator tests (
_unique,_unique2,unique_dim) and reuses PyTorch's standard test infrastructure.Fixes #2695