Ensure exporter creates valid python name for opset vars#1051
Merged
gramalingam merged 6 commits intomainfrom Sep 7, 2023
Merged
Ensure exporter creates valid python name for opset vars#1051gramalingam merged 6 commits intomainfrom
gramalingam merged 6 commits intomainfrom
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
reviewed
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 77.75% 77.78% +0.02%
==========================================
Files 114 114
Lines 14489 14517 +28
Branches 1549 1554 +5
==========================================
+ Hits 11266 11292 +26
- Misses 2857 2858 +1
- Partials 366 367 +1
📢 Have feedback on the report? Share it here. |
justinchuby
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing exporter creates invalid python identifiers like "onnxscript.atenlib1" when generating variable names for opsets. Change this to create a name like "onnxscript_atenlib1".