Fix native component definitions to codegen in all situations#4027
Fix native component definitions to codegen in all situations#4027
Conversation
…tive into user/jasonvmo/fix-native-components
🦋 Changeset detectedLatest commit: 7f526e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "prettier.singleQuote": true, | ||
| "prettier.tabWidth": 2, | ||
| "prettier.printWidth": 140, | ||
| "prettier.trailingComma": "all", |
There was a problem hiding this comment.
Not sure if oxfmt respects this? Regardless probably delete? There's a way to make oxfmt so format on save
There was a problem hiding this comment.
For now we have the prettier formatter still being the one in vscode. I've found the oxc plugin is kind of crashy right now so until we make that work this is a stopgap so that we don't get immediate conflicts on save.
| | 'rightCenter' | ||
| | 'rightBottomEdge' | ||
| | 'bottonLeftEdge' | ||
| | 'bottomLeftEdge' |
There was a problem hiding this comment.
Maybe a breaking change to internal code. Particularly Excel.
| @@ -1,15 +1,13 @@ | |||
| import type * as React from 'react'; | |||
| import type { KeyboardMetrics, ViewStyle, ViewProps } from 'react-native'; | |||
| import type { KeyboardMetrics, ViewStyle } from 'react-native'; | |||
There was a problem hiding this comment.
A note... Callout never got a version with the v1 framework. Would be good AI fodder one day..
2 participants
Platforms Impacted
Description of changes
Codegen's ability to find things like type files varies quite a bit. When running directly from typescript files:
This fixes bundling against 81 (combined with the default exports fix), allowing codegen to run as part of the bundle and build.
Verification
Combination of manual steps, and automated tests.