Skip to content

style: add visual divider between folders and items in workspace listing#165

Open
ayeshurun wants to merge 246 commits intomicrosoft:mainfrom
ayeshurun:copilot/add-divider-to-ls-output
Open

style: add visual divider between folders and items in workspace listing#165
ayeshurun wants to merge 246 commits intomicrosoft:mainfrom
ayeshurun:copilot/add-divider-to-ls-output

Conversation

@ayeshurun
Copy link
Collaborator

@ayeshurun ayeshurun commented Feb 3, 2026

📥 Pull Request

This PR enhances the fab ls command by adding a visual divider to improve the readability of workspace listings.

✨ Description of new changes

  • Visual Divider: A ------------------------------ divider now separates folders from items in the output.
  • Conditional Display: The divider only appears when folder_listing_enabled=true, output_format=text, and the --long flag is not used.
  • Implementation: The divider is added as a data entry, avoiding changes to core rendering logic.

This change provides a clearer distinction between content types in the workspace, improving user experience for large workspaces.

Example Output

Sales.Folder
Marketing.Folder
Engineering.Folder
------------------------------
Product-Catalog.SemanticModel
Sales-Dashboard.Report
Inventory.SemanticModel
Customer-Data.Report

ayeshurun and others added 30 commits September 17, 2025 17:11
chore: Introduce release workflowc
Alon Yeshurun and others added 21 commits February 19, 2026 15:47
- Add 'Needs Author Feedback' assessment category to all 3 prompts
- Rename 'Missing Details' to 'Needs Author Feedback' in bug-triage
- Add new category to question-triage and feature-triage
- Remove redundant response text fallback and needsHumanReview override
- Update workflow label detection to match new category name

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Merge Needs Maintainer Input and Needs Team Review into single
  Needs Team Review category in question-triage prompt
- Remove duplicate needs author feedback label from post-processing
  (action's ai:* label is sufficient)
- Remove ai:* label cleanup (keep action's assessment labels)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract CLI commands, flags, item types, auth methods, and error
codes from actual source files. Inject into system prompt (not issue
body) so AI backs up answers with real codebase data. Comments and
issue body stay clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All AI triage comments now end with a footer instructing users
to tag @microsoft/fabric-cli-dev if the issue needs team attention
but wasn't escalated by the AI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Approach A (Action): github/ai-assessment-comment-labeler with codebase context injection
- Approach B (Code Agent): Custom scripts/ai_triage.py that greps source code and injects into prompt
- Both trigger on 'needs triage' label and post tagged comments (🅰️/🅱️)
- Both include collapsible label decision tables in comments
- Labels suppressed on both for fair testing
- Added CLI doc page URLs to all 3 prompt files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- A: Use yaml.safe_load/dump to avoid YAML alias errors from markdown **bold**
- A: Remove bold markdown from injected context text
- B: Reduce code context limits (30K total, 4K/file, 8 files max)
- B: Add API error details to stderr for debugging

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Bug: Potential Bug and Needs Team Review → Escalated to team
- Question: Tied each category explicitly to its footer
- Feature: Tied each category explicitly to its footer
- Removed stale Codebase Reference instruction from feature prompt

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove numbered dimension checklists from all 3 prompts
- Instruct model to skip adequate aspects, highlight only missing/wrong/notable
- Reduce target length from 3-5 to 2-4 paragraphs
- Trim verbose preamble in ai_triage.py code context header

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Valuable Enhancement → 📋 Backlog candidate (no escalation)
- Help Wanted → 🤝 Community contribution welcome
- Out of Scope → ✅ No action needed
- Add 'needs discussion' to needsHumanReview in both workflows

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add tailored PEP/RFC/convention references to each prompt:
- Bug: packaging, CLI conventions, HTTP/REST, auth, file I/O, runtime
- Question: packaging, CLI conventions, HTTP/REST, auth, data formats
- Feature: CLI conventions, packaging, HTTP/REST, backward compat, auth

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mpts

- Remove Approach B (agent workflow + ai_triage.py), archived on branch
- Move codebase reference from pipeline build step into prompt files
- Prompts now self-contained: commands, flags, item types, auth, hidden entities
- Remove /tmp/prompts indirection, use .github/prompts directly
- Clean up A/B testing artifacts (tagged comments, approach labels)
- Restore phase control flags (SUPPRESS_LABELS + SUPPRESS_COMMENTS)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…inks

Reference https://microsoft.github.io/fabric-cli/essentials/resource_types/
instead of static lists, keeping prompts always up to date.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…s_item

Wraps sorted_elements_dict[0].keys() with list() to satisfy
the list[str] type expected by format_and_print_output().

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants