Add missing input validation to SuspendInstanceAsync and ResumeInstan…#652
Merged
YunchuWang merged 2 commits intomainfrom Feb 27, 2026
Merged
Add missing input validation to SuspendInstanceAsync and ResumeInstan…#652YunchuWang merged 2 commits intomainfrom
YunchuWang merged 2 commits intomainfrom
Conversation
…ceAsync Add Check.NotNullOrEmpty(instanceId) to SuspendInstanceAsync and ResumeInstanceAsync for consistency with all other instance-targeted methods (RaiseEventAsync, TerminateInstanceAsync, GetInstancesAsync, PurgeInstancesAsync, etc.) which already have this validation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing input validation (Check.NotNullOrEmpty(instanceId)) to SuspendInstanceAsync and ResumeInstanceAsync in GrpcDurableTaskClient, making them consistent with other instance-targeted methods such as RaiseEventAsync, TerminateInstanceAsync, GetInstancesAsync, and PurgeInstancesAsync, which already have this validation.
Changes:
- Added
Check.NotNullOrEmpty(instanceId)at the start ofSuspendInstanceAsyncinGrpcDurableTaskClient - Added
Check.NotNullOrEmpty(instanceId)at the start ofResumeInstanceAsyncinGrpcDurableTaskClient
kaibocai
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ceAsync
Add Check.NotNullOrEmpty(instanceId) to SuspendInstanceAsync and ResumeInstanceAsync for consistency with all other instance-targeted methods (RaiseEventAsync, TerminateInstanceAsync, GetInstancesAsync, PurgeInstancesAsync, etc.) which already have this validation.
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers