Fix int.MinValue overflow and CTS disposal in DistributedTracingSample#649
Merged
torosent merged 2 commits intotorosent/add-otel-samplefrom Feb 27, 2026
Merged
Fix int.MinValue overflow and CTS disposal in DistributedTracingSample#649torosent merged 2 commits intotorosent/add-otel-samplefrom
torosent merged 2 commits intotorosent/add-otel-samplefrom
Conversation
15 tasks
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add OpenTelemetry sample and update dependencies
Fix int.MinValue overflow and CTS disposal in DistributedTracingSample
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two correctness issues in the
DistributedTracingSampleGetWeatheractivity identified during review.Changes
Math.Absoverflow (Program.cs):Math.Abs(int.MinValue)overflows back toint.MinValue(still negative), causingIndexOutOfRangeExceptionon the modulo. Replaced with auintcast, which is both overflow-safe and removes the doubleGetHashCode()call:CancellationTokenSourcedisposal: Addedusingdeclaration so the underlying timer is released when the token source goes out of scope.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.