Fix build warnings and clean up exception message#647
Merged
YunchuWang merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
- Remove duplicate BenchmarkDotNet 0.14.0 entry in Directory.Packages.props (fixes NU1506) - Upgrade ExportHistoryWebApp from net6.0 to net8.0 (fixes NETSDK1138) - Remove 'TODO' prefix from exception message in TaskHubGrpcServer
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses build warnings and improves code quality by removing a duplicate package reference, upgrading a sample to a supported .NET version, and cleaning up a user-facing exception message.
Changes:
- Removed duplicate BenchmarkDotNet 0.14.0 entry from Directory.Packages.props (fixes NU1506 warning)
- Upgraded ExportHistoryWebApp sample from net6.0 to net8.0 (fixes NETSDK1138 warning and aligns with other samples)
- Removed 'TODO' prefix from exception message in TaskHubGrpcServer and improved punctuation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Packages.props | Removed duplicate BenchmarkDotNet package version entry (0.14.0), keeping the newer 0.15.8 version |
| samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj | Updated target framework from net6.0 to net8.0 to align with other samples and support current .NET versions |
| src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs | Cleaned up exception message by removing TODO prefix and improving punctuation for a more professional user-facing error |
kaibocai
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers