Skip to content

Fix build warnings and clean up exception message#647

Merged
YunchuWang merged 1 commit intomainfrom
wangbill/code-quality-fixes
Feb 27, 2026
Merged

Fix build warnings and clean up exception message#647
YunchuWang merged 1 commit intomainfrom
wangbill/code-quality-fixes

Conversation

@YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Feb 27, 2026

  • Remove duplicate BenchmarkDotNet 0.14.0 entry in Directory.Packages.props (fixes NU1506)
  • Upgrade ExportHistoryWebApp from net6.0 to net8.0 (fixes NETSDK1138)
  • Remove 'TODO' prefix from exception message in TaskHubGrpcServer

Summary

What changed?

Why is this change needed?

Issues / work items

  • Resolves #
  • Related #

Project checklist

  • Release notes are not required for the next release
    • Otherwise: Notes added to release_notes.md
  • Backport is not required
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • All required tests have been added/updated (unit tests, E2E tests)
  • Breaking change?
    • If yes:
      • Impact:
      • Migration guidance:

AI-assisted code disclosure (required)

Was an AI tool used? (select one)

  • No
  • Yes, AI helped write parts of this PR (e.g., GitHub Copilot)
  • Yes, an AI agent generated most of this PR

If AI was used:

  • Tool(s):
  • AI-assisted areas/files:
  • What you changed after AI output:

AI verification (required if AI was used):

  • I understand the code and can explain it
  • I verified referenced APIs/types exist and are correct
  • I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions)
  • I reviewed concurrency/async behavior
  • I checked for unintended breaking or behavior changes

Testing

Automated tests

  • Result: Passed / Failed (link logs if failed)

Manual validation (only if runtime/behavior changed)

  • Environment (OS, .NET version, components):
  • Steps + observed results:
    1.
    2.
    3.
  • Evidence (optional):

Notes for reviewers

  • N/A

- Remove duplicate BenchmarkDotNet 0.14.0 entry in Directory.Packages.props (fixes NU1506)
- Upgrade ExportHistoryWebApp from net6.0 to net8.0 (fixes NETSDK1138)
- Remove 'TODO' prefix from exception message in TaskHubGrpcServer
Copilot AI review requested due to automatic review settings February 27, 2026 04:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses build warnings and improves code quality by removing a duplicate package reference, upgrading a sample to a supported .NET version, and cleaning up a user-facing exception message.

Changes:

  • Removed duplicate BenchmarkDotNet 0.14.0 entry from Directory.Packages.props (fixes NU1506 warning)
  • Upgraded ExportHistoryWebApp sample from net6.0 to net8.0 (fixes NETSDK1138 warning and aligns with other samples)
  • Removed 'TODO' prefix from exception message in TaskHubGrpcServer and improved punctuation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Removed duplicate BenchmarkDotNet package version entry (0.14.0), keeping the newer 0.15.8 version
samples/ExportHistoryWebApp/ExportHistoryWebApp.csproj Updated target framework from net6.0 to net8.0 to align with other samples and support current .NET versions
src/InProcessTestHost/Sidecar/Grpc/TaskHubGrpcServer.cs Cleaned up exception message by removing TODO prefix and improving punctuation for a more professional user-facing error

@YunchuWang YunchuWang merged commit a4e8cc2 into main Feb 27, 2026
12 checks passed
@YunchuWang YunchuWang deleted the wangbill/code-quality-fixes branch February 27, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants