This repository was archived by the owner on May 20, 2025. It is now read-only.
Add upper bound for parse-duration package version#97
Merged
lucen-ms merged 1 commit intomicrosoft:mainfrom Feb 14, 2025
priitlatt:deps/parse-duration-version
Merged
Add upper bound for parse-duration package version#97lucen-ms merged 1 commit intomicrosoft:mainfrom priitlatt:deps/parse-duration-version
lucen-ms merged 1 commit intomicrosoft:mainfrom
priitlatt:deps/parse-duration-version
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Codemagic" |
nathaliatemudo-abi
approved these changes
Feb 13, 2025
|
@lucen-ms if you can approve this please |
lucen-ms
approved these changes
Feb 14, 2025
Collaborator
|
Thank you @icarusdust - we will fix it properly soon. |
|
Huge thanks to @priitlatt 🙏 |
itujo
pushed a commit
to Idea-Maker/code-push-server
that referenced
this pull request
Feb 21, 2025
NPM package [parse-duration](https://www.npmjs.com/package/parse-duration) version was bumped from `1.1.0` to `2.1.3` In PR microsoft#95 for CodePush CLI. This caused the build to fail with the following error: ```shell % npm run build > code-push-cli@0.0.1 build > tsc script/command-parser.ts:1321:21 - error TS2349: This expression is not callable. Type 'typeof import("/private/tmp/ms-code-push-server/cli/node_modules/parse-duration/index")' has no call signatures. 1321 return Math.floor(parseDuration(durationString)); ~~~~~~~~~~~~~ Found 1 error in script/command-parser.ts:1321 ``` As current code-base is not compatible with `parse-duration` versions `2.0.0+`, restrict `parse-duration` to use version `1.x.y`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPM package parse-duration version was bumped from
1.1.0to2.1.3In PR #95 for CodePush CLI. This caused the build to fail with the following error:As current code-base is not compatible with
parse-durationversions2.0.0+, restrictparse-durationto use version1.x.y.