Skip to content

Updates to tutorials#3

Open
hgilles06 wants to merge 8 commits intomicrosoft:mainfrom
hgilles06:main
Open

Updates to tutorials#3
hgilles06 wants to merge 8 commits intomicrosoft:mainfrom
hgilles06:main

Conversation

@hgilles06
Copy link
Copy Markdown

Updating building-volume-tutorial.ipynb
Adding support for running analyses on locally downloaded data
Adding a notebook (download-tiles.ipynb) to download the Tempo dataset

@hgilles06
Copy link
Copy Markdown
Author

@hgilles06 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@calebrob6
Copy link
Copy Markdown
Member

I love the idea of having a script to download all the data locally, but I think it makes more sense to be a .py utility-like script instead of a notebook. Can you refactor the notebook functionality into a script that lives in scripts/ (or even the root directory) and add a "Download All" type section to the README that explains how to use it?

@tamara-glazer any thoughts on the new notebook design?

@tamara-glazer
Copy link
Copy Markdown

The new notebook looks good! The initial setup block is quite a bit of code upfront; I think this would be a little more digestible if broken up with some descriptive text between each, explaining why the function is needed; for now will fall back to the docstrings. No need to update for this merge.
cc @hgilles06

I agree that data download should be abstracted into a script, and then called in. I pulled the code from this notebook into a separate script, will commit separately (can't test properly until opendata.aiforgood.ai is added to the "allow" list).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants