feat(add package): add rust-ripgrep to the package list for azl4#16165
Open
binujp wants to merge 1 commit intotomls/base/mainfrom
Open
feat(add package): add rust-ripgrep to the package list for azl4#16165binujp wants to merge 1 commit intotomls/base/mainfrom
binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
This is PR is meant to both add ripgrep, which is a useful and required tool, while working out requirements and process to add a new package to azl4. Why: The technical argument for ripgrep is captured by the ripgrep author in this blog post https://burntsushi.net/ripgrep/. For a dev workdlow it is an essential tool and is used under the covers by other IDEs including vscode. Dependecies: It has a static build dependency on cargo-rpm-macros >= 24 which is already available in the azl4 closure. There are a set of dynamic build dependencies from %cargo_generate_buildrequires: rust-bstr rust-crossbeam-deque rust-crossbeam-epoch rust-crossbeam-utils rust-encoding_rs rust-encoding_rs_io rust-globset rust-grep rust-grep-cli rust-grep-matcher rust-grep-pcre2 rust-grep-printer rust-grep-regex rust-grep-searcher rust-ignore rust-lexopt rust-memmap2 rust-pcre2 rust-pcre2-sys rust-same-file rust-walkdir Testing: Built the package locally on x86 and arm64. Ran the binary on both platforms.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new component stanza to the full component inventory list used by base/comps/components.toml includes.
Changes:
- Add
[components.rust-ripgrep]entry tocomponents-full.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
2960
to
2963
| [components.rgb] | ||
| [components.rhash] | ||
| [components.rust-ripgrep] | ||
| [components.rlottie] |
There was a problem hiding this comment.
[components.rust-ripgrep] is out of sort order in this file. The surrounding entries are alphabetized (rhash, rlottie, …), and there is already a large rust-* block later in the file (e.g., rust-ring, rust-ripemd, rust-rkyv). Please move this entry into the correct alphabetical position within the existing rust-* section (likely after rust-ripemd).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR is meant to both add ripgrep, a useful and important dev-tool, while working out requirements and processes to add a new package to azl4.
Why: The technical argument for ripgrep is captured by the ripgrep author in this blog post https://burntsushi.net/ripgrep/. For a dev workflow it is an essential tool and is used under the covers by various IDEs including vscode.
Dependencies: It has a static build dependency on cargo-rpm-macros >= 24 which is already available in the azl4 closure. There are a set of dynamic build dependencies from %cargo_generate_buildrequires:
rust-bstr
rust-crossbeam-deque
rust-crossbeam-epoch
rust-crossbeam-utils
rust-encoding_rs
rust-encoding_rs_io
rust-globset
rust-grep
rust-grep-cli
rust-grep-matcher
rust-grep-pcre2
rust-grep-printer
rust-grep-regex
rust-grep-searcher
rust-ignore
rust-lexopt
rust-memmap2
rust-pcre2
rust-pcre2-sys
rust-same-file
rust-walkdir
Testing: Built the package locally on x86 and arm64. Ran the binary on both platforms.
Rationale: Ripgrep is a must-have in a dev environment and workflow. Grep and other legacy tools cannot substitute its flexibility and performance. The new packages being brought in are rust-crates. Given the increasing surface area of "rusty" tools, we will need all the popular crates sooner or later. Path of least resistance is not fighting the fedora package system. These are all build dependencies and does not get exposed to the user. Maintenance overhead is minimal and given the nature of consumption, mostly automated.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology