Skip to content

docs: move to docker secret mount for passing in pat token#656

Merged
embetten merged 8 commits intomasterfrom
users/embetten/docker-docs
Mar 13, 2026
Merged

docs: move to docker secret mount for passing in pat token#656
embetten merged 8 commits intomasterfrom
users/embetten/docker-docs

Conversation

@embetten
Copy link
Contributor

@embetten embetten commented Mar 11, 2026

#655

@jpinz
Copy link
Member

jpinz commented Mar 12, 2026

I think that looks fine, I would suggest testing it and then doing a docker inspect to confirm there's no leaks.
If you'd like, you can also build it, then save as a tarball and send it to me (over teams or email) and I can inspect it.

Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
@embetten
Copy link
Contributor Author

I think that looks fine, I would suggest testing it and then doing a docker inspect to confirm there's no leaks. If you'd like, you can also build it, then save as a tarball and send it to me (over teams or email) and I can inspect it.

Done! also moved the config values to export in the same RJN command as well. This will be more annoying for users that need to run multiple build and restore commands, but will ensure none of the config settings are persisted in the image either.

@embetten
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@embetten embetten merged commit cf742fa into master Mar 13, 2026
55 checks passed
@embetten embetten deleted the users/embetten/docker-docs branch March 13, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants