.NET: Fix role assignment in ChatMessage construction#4290
Open
AkiKurisu wants to merge 1 commit intomicrosoft:mainfrom
Open
.NET: Fix role assignment in ChatMessage construction#4290AkiKurisu wants to merge 1 commit intomicrosoft:mainfrom
AkiKurisu wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Replace hard-coded ChatRole.User with a ChatRole constructed from the message's Role. The change ensures ToChatMessage and FunctionMessage use the original role (new ChatRole(this.Role)) for both text and contents branches, fixing incorrect role assignment when constructing ChatMessage instances.
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4289
ChatCompletionRequestMessage.ToChatMessage()hardcodesChatRole.Userfor all message types, causing multi-turn conversations via the ChatCompletions hosting path to lose role information. The LLM receives every message (including its own previous assistant replies, system messages, developer messages, etc.) asuserrole, breaking conversation coherence.Changes
ChatCompletionRequestMessage.ToChatMessage()(base class): replaced hardcodedChatRole.Userwithnew ChatRole(this.Role)so each derived type (UserMessage,AssistantMessage,SystemMessage,DeveloperMessage,ToolMessage) maps to its correct role.FunctionMessage.ToChatMessage()(override): same fix applied.This aligns the ChatCompletions path with the Responses path, where
InputMessage.ToChatMessage()already correctly usesthis.Role.Motivation and Context
Description
Contribution Checklist