Skip to content

fix: return Promise from Model.download() to enable await with progress callback #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baijumeswani merged 2 commits into from
Feb 28, 2026
+21 −3
Merged

fix: return Promise from Model.download() to enable await with progress callback #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a3b7bb
Initial plan
Copilot Feb 28, 2026
3971c80
Merge main into branch: resolve conflicts keeping Promise<void> fix
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-cs-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
clean: true

- name: Setup .NET 9 SDK
- name: Setup .NET 10 SDK
uses: actions/setup-dotnet@v5
with:
dotnet-version: '9.0.x'
dotnet-version: '10.0.x'
env:
NUGET_AUTH_TOKEN: ${{ secrets.AZURE_DEVOPS_PAT }}

Expand Down
20 changes: 19 additions & 1 deletion sdk_v2/js/script/install.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const CORE_FEED = useNightly ? ORT_NIGHTLY_FEED : NUGET_FEED;
const ARTIFACTS = [
{
name: useWinML ? 'Microsoft.AI.Foundry.Local.Core.WinML' : 'Microsoft.AI.Foundry.Local.Core',
version: useNightly ? undefined : useWinML ? '0.9.0.2-dev-20260226T191541-2b332047' : '0.9.0.4-dev-20260226T191638-2b332047', // Set later using resolveLatestVersion if undefined
version: useNightly ? undefined : useWinML ? '0.9.0.2-dev-20260226T191541-2b332047' : '0.9.0-dev-20260227T222239-2a3af92', // Set later using resolveLatestVersion if undefined
feed: ORT_NIGHTLY_FEED
},
{
Expand Down Expand Up @@ -271,12 +271,30 @@ async function installPackage(artifact, tempDir) {
}
}

// ORT 1.24.1 has a bug: https://github.com/microsoft/onnxruntime/issues/27263
// Resolve it by creating a symlink to the correct binary on Linux and macOS.
function createOnnxRuntimeSymlinks() {
if (os.platform() === 'win32') return;

const ext = os.platform() === 'darwin' ? '.dylib' : '.so';
const libName = `libonnxruntime${ext}`;
const linkName = `onnxruntime.dll`;
const libPath = path.join(BIN_DIR, libName);
const linkPath = path.join(BIN_DIR, linkName);
if (fs.existsSync(libPath) && !fs.existsSync(linkPath)) {
fs.symlinkSync(libName, linkPath);
console.log(`[foundry-local] Created symlink: ${linkName} -> ${libName}`);
}
}


async function main() {
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'foundry-install-'));
try {
for (const artifact of ARTIFACTS) {
await installPackage(artifact, tempDir);
}
createOnnxRuntimeSymlinks();
console.log('[foundry-local] ✓ Installation complete.');
} catch (e) {
console.error(`[foundry-local] Installation failed: ${e.message}`);
Expand Down