fix: return promise from Model.download() to enable await with progre…#467
Merged
baijumeswani merged 3 commits intomainfrom Feb 28, 2026
Merged
fix: return promise from Model.download() to enable await with progre…#467baijumeswani merged 3 commits intomainfrom
baijumeswani merged 3 commits intomainfrom
Conversation
…ss callback Model.download() was discarding the Promise returned by ModelVariant.download(), causing await to resolve immediately. This meant load() could run before the download completed, resulting in 'Model path does not exist' errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
prathikr
approved these changes
Feb 27, 2026
Contributor
|
@copilot please merge main into this branch |
Contributor
|
@baijumeswani I've opened a new pull request, #474, to work on those changes. Once the pull request is ready, I'll request review from you. |
…ss callback (#474) * Initial plan * Merge main into branch: resolve conflicts keeping Promise<void> fix Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com>
baijumeswani
approved these changes
Feb 28, 2026
prathikr
pushed a commit
that referenced
this pull request
Feb 28, 2026
#467) * fix: return promise from Model.download() to enable await with progress callback Model.download() was discarding the Promise returned by ModelVariant.download(), causing await to resolve immediately. This meant load() could run before the download completed, resulting in 'Model path does not exist' errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: return Promise from Model.download() to enable await with progress callback (#474) * Initial plan * Merge main into branch: resolve conflicts keeping Promise<void> fix Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model.download() was discarding the Promise returned by ModelVariant.download(), causing await to resolve immediately. This meant load() could run before the download completed, resulting in 'Model path does not exist' errors.